Merged
Conversation
Collaborator
Author
|
Depends on #71. Merge it first! |
melekes
changed the title
Collaborator
|
I wanted to merge Looks good. |
greg-szabo
approved these changes
May 28, 2025
melekes
force-pushed
the
KaiserKarel_expose-reqwest-client
branch
from
562cb5e to
8634e3c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the ability to provide a custom reqwest client in the RPC HTTP client configuration. Key changes include:
- Addition of an optional reqwest::Client field and corresponding setter (client()) in the Builder struct.
- Provision of a new HttpClient constructor (new_from_parts) that accepts a user-supplied reqwest client.
- Minor improvements in the builder method chain, such as using unwrap_or_else for user_agent.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rpc/src/client/transport/http.rs | Adds the reqwest::Client field, a new client() setter, and new_from_parts() constructor. |
| .changelog/unreleased/features/38-reqwest-client.md | Documents the new client() and new_from_parts() methods supporting custom client injection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port-of: cometbft/tendermint-rs#1421
Closes #38