Add TypeScript Runtime Support and add Prisma 7 Compatibility by MickLesk · Pull Request #354 · community-scripts/ProxmoxVE-Local

MickLesk · 2025-11-28T11:19:02Z

✍️ Description

This PR introduces comprehensive TypeScript runtime support via tsx and resolves critical compatibility issues with Prisma 7, enabling the application to run successfully in production. The changes span type safety improvements, module resolution fixes, and production deployment readiness.

📋 Changes Summary (30 Commits)

🔧 Core Infrastructure Changes

TypeScript Runtime Support

Added tsx@^4.19.4 as a production dependency
Updated start script: node server.js → node --import tsx server.js
Updated dev:server script for consistency: node --import tsx server.js
Enables native TypeScript execution without compilation step
Supports .ts file loading in production environment

Module Resolution & Imports

Fixed import paths across all service files for ESM compatibility
Added .ts extensions to TypeScript imports where required
Updated relative imports to work with tsx loader
Ensured consistent import patterns across codebase

🐛 Bug Fixes

Prisma 7 Compatibility

Updated src/server/db.js to properly import Prisma 7 client
Fixed path resolution for prisma/generated/prisma/client.ts
Handled ESM/CJS interoperability issues with Prisma
Resolved module resolution errors in generated Prisma types

Server Initialization Issues

Added missing initializeRepositories() export to src/server/lib/autoSyncInit.ts
Fixed repository initialization on server startup
Resolved TypeError: autoSyncModule.initializeRepositories is not a function
Ensured default repositories are loaded before API requests

Service Module Exports

Fixed exports in src/server/services/autoSyncService.js
Fixed exports in src/server/services/repositoryService.js
Fixed exports in src/server/services/githubJsonService.js
Ensured all service modules properly export their functions

Dynamic Import Implementation

Converted static imports to dynamic imports for autoSyncInit module
Added comprehensive logging for debugging module loading
Implemented error handling for failed module imports
Better error messages during server initialization

✨ Features & Improvements

Development Experience

dev:server command for development with TypeScript support
Detailed logging for module initialization debugging
Better error messages showing available vs. requested exports
Improved troubleshooting for module resolution issues

Production Readiness

Full TypeScript support in production environment
Proper module caching and tsx handling
Graceful error handling during server startup
WebSocket server initialization logging

Type Safety

TypeScript strict mode compatible code
Proper type definitions for all service modules
Better IDE support with TypeScript paths
Type checking via npm run typecheck

📝 Files Modified

Category	Files	Changes
Configuration	`package.json`	Added `tsx` dependency; Updated start/dev scripts
Core Server	`server.js`	Added dynamic imports with detailed logging
Database	`src/server/db.js`	Fixed Prisma client import paths
Initialization	`src/server/lib/autoSyncInit.ts`	Added `initializeRepositories()` export; Added TypeScript definitions
Services	`src/server/services/autoSyncService.js`	Fixed import paths and exports
Services	`src/server/services/repositoryService.js`	Fixed import paths and exports
Services	`src/server/services/githubJsonService.js`	Fixed import paths and exports
Type Definitions	`src/server/database-prisma.ts`	Fixed `any` type issues; Added explicit return types

🔍 Technical Details

What Was Wrong

Prisma 7 generates TypeScript but production was trying to run JavaScript
Module exports were missing from some .ts files while .js versions had them
Import paths were inconsistent - some with extensions, some without
Static imports failed due to tsx caching issues
No logging made debugging difficult

How It Was Fixed

Added tsx runtime to handle TypeScript in production
Synced .ts and .js exports to match
Standardized import paths for ESM compatibility
Switched to dynamic imports for better module loading
Added comprehensive logging for troubleshooting

✅ Testing & Verification

✅ npm install completes without errors
✅ npm run build completes successfully
✅ npm run typecheck passes with no errors
✅ npm run lint and npm run format:check pass
✅ npm start runs without errors
✅ Server initializes all services (WebSocket, auto-sync, repositories)

📊 Commit Overview

30 commits across:

Type safety improvements (6 commits)
Import path fixes (8 commits)
Module export fixes (7 commits)
Service configuration (5 commits)
Documentation and logging (4 commits)

🔗 Related Issues

Production deployment failures with Prisma 7
TypeScript/ESM module resolution
Server initialization on startup
Missing service exports

✅ Prerequisites

Self-review completed – Code follows project standards
Tested thoroughly – Verified on multiple environments
No security risks – No hardcoded secrets or privilege escalations

🛠️ Type of Change

🐞 Bug fix only
✨ New feature – TypeScript runtime support via tsx
💥 Breaking change – Production startup mechanism changed

Upgraded multiple dependencies and devDependencies in package.json to their latest versions for improved stability and features. Changed the TypeScript 'jsx' compiler option from 'react-jsx' to 'preserve' in tsconfig.json to better align with project requirements.

…nal-chain, unescaped-entities, unused-vars, type-safety

Improves type safety and normalization in filter, repository, and script status handling across multiple components. Refactors ScriptsGrid for better readability, deduplication, and error messaging, and updates UI markup for consistency. Also adds explicit types for auto-sync settings and ensures string conversion for credential fields.

Replaces many uses of logical OR (||) with nullish coalescing (??) for more accurate handling of undefined/null values. Adds explicit type annotations and interfaces to improve type safety, especially in API routes and server-side code. Updates SSH connection test handling and config parsing in installedScripts router for better reliability. Minor fixes to deduplication logic, cookie handling, and error reporting.

Standardizes quote usage, formatting, and code style in InstalledScriptsTab.tsx. Improves readability and maintains consistent conventions across the file without changing logic or functionality.

Updated InstalledScriptsTab.tsx to use double quotes and consistent formatting throughout the file. Improved type annotations, code readability, and standardized state initialization and mutation usage. No functional changes were made; this is a style and maintainability refactor.

Added and updated eslint-disable comments in repositoryService, restoreService, and storageService to cover additional TypeScript rules. Simplified error handling by removing unused variables and catch parameters, and removed unused imports and variables in restoreService for cleaner code.

Replaces @eslint/eslintrc and FlatCompat with eslint-config-next/core-web-vitals for ESLint configuration. Updates linting scripts in package.json to use eslint directly instead of next lint. Removes @eslint/eslintrc from devDependencies.

Switched to using FlatCompat for ESLint configuration and extended the ignore list to include 'next-env.d.ts', 'postcss.config.js', and 'prettier.config.js'. This improves compatibility and prevents linting of config and environment files.

Added explicit type annotations to array mapping functions for better type safety. Updated incorrect TypeScript import extensions from .ts to .js for compatibility. Ensured default values for optional parameters and improved code clarity in API routers.

Updated several components to use explicit TypeScript types for better type safety. Normalized appriseUrls to always be an array in auto-sync settings API. Improved handling of optional server_id in BackupsTab and adjusted IP detection logic in InstalledScriptsTab. Removed unnecessary eslint-disable comments and improved code clarity in various places.

Set `checkJs` to true to allow type checking for JavaScript files. Updated include/exclude patterns to support JS and CJS files in the project.

Replaces usage of PrismaBetterSQLite3 with PrismaBetterSqlite3 for consistency and correct casing. Updates type annotations in several components and API router for improved type safety. Also adjusts PrismaClient import paths in db files.

Enhanced type safety and documentation in several files, including adding explicit type annotations for script objects and function parameters. Improved error handling and code clarity in scriptDownloader.js, and updated autoSyncService.js to remove unnecessary cron job options. Refactored prisma.config.ts for schema configuration and updated server.js to support backup storage and improve parameter defaults.

Upgraded Prisma and related dependencies to version 7.0.1 and added @prisma/adapter-better-sqlite3 and better-sqlite3 to support the new adapter. This enables improved SQLite integration and compatibility with the latest Prisma features.

Added detailed JSDoc comments and type annotations to ScriptDownloaderService for better maintainability and clarity. Refactored initialization logic to always set scriptsDirectory and repoUrl. Enhanced autoSyncService to specify cron job timezone and options. Updated PrismaClient import path for compatibility with generated client structure.

Removed or updated unnecessary eslint-disable comments across several server and service files to improve code clarity. Fixed import paths and added TypeScript ignore comments where needed for compatibility. Minor formatting adjustments were made for readability.

Updated import statements across several server files to omit explicit file extensions. This improves compatibility with module resolution and aligns with common import practices.

Updated the initialization logic to use the 'recursive' option when creating the data/ssh-keys directory, ensuring parent directories are created if they do not exist.

…pts.js)

This commit adds TypeScript type definitions for database entities and updates all methods in DatabaseServicePrisma to use explicit type annotations and return types. This improves type safety, code clarity, and maintainability by ensuring consistent return values and better integration with Prisma-generated types.

This reverts commit aebc8a6.

…ervice) and fix .js import extensions

…atibility

…ma 7, tsx support)

MickLesk and others added 30 commits November 28, 2025 11:44

fix vulnerabilities

f467b9a

fix: ESLint/TypeScript fixes - nullish coalescing, regexp-exec, optio…

9c759ba

…nal-chain, unescaped-entities, unused-vars, type-safety

Refactor InstalledScriptsTab for code style consistency

b5bce88

Standardizes quote usage, formatting, and code style in InstalledScriptsTab.tsx. Improves readability and maintains consistent conventions across the file without changing logic or functionality.

Fix: Remove .js extensions from TypeScript imports for Next.js bundler

987ac3d

Enable JS type checking in tsconfig.json

2d71769

Set `checkJs` to true to allow type checking for JavaScript files. Updated include/exclude patterns to support JS and CJS files in the project.

Migration to Prisma 7

1a5881c

upgrade betterauthsql

1a1dbe6

Update Prisma adapter and type annotations

7fa132e

Replaces usage of PrismaBetterSQLite3 with PrismaBetterSqlite3 for consistency and correct casing. Updates type annotations in several components and API router for improved type safety. Also adjusts PrismaClient import paths in db files.

Fix Prisma import path in db.js and update allowedDevOrigins format

c57586a

Fix repositoryService import extension in autoSyncInit.js

737c9c9

Remove file extensions from import statements

e0baa79

Updated import statements across several server files to omit explicit file extensions. This improves compatibility with module resolution and aligns with common import practices.

Ensure recursive creation of ssh-keys directory

69c10b0

Updated the initialization logic to use the 'recursive' option when creating the data/ssh-keys directory, ensuring parent directories are created if they do not exist.

Add datasource property to Prisma config for migrate/db push support

3a2a1b2

Fix cross-origin cookie issues: use lax SameSite and add CORS headers

94eb772

Remove circular import wrapper files (githubJsonService.js, localScri…

3a4f869

…pts.js)

Remove .js extensions from dynamic imports

bef5bef

Fix login race condition: don't call checkAuth after successful login

c5db169

MickLesk added 19 commits November 28, 2025 13:41

Auto-initialize default repositories on first API call

aebc8a6

Revert "Auto-initialize default repositories on first API call"

3dabacd

This reverts commit aebc8a6.

Fix ESM import in database-prisma.js - add .js extension

5ea6828

Add JS wrappers for ESM compatibility (repositoryService, githubJsonS…

dbc591a

…ervice) and fix .js import extensions

Fix db.js import - add .js extension for Prisma client

691b27c

Fix db.js - import PrismaClient from @prisma/client for Node ESM comp…

d64a296

…atibility

Fix db.js - use CommonJS-style import for @prisma/client

1e25030

Fix db.js - import from .prisma/client runtime location

a787e60

Fix db.js - use createRequire to load .prisma/client CJS module

b54fbf1

Fix db.js - use absolute path to .prisma/client

31a5fd9

Fix db.js - require index.js explicitly

644222e

Use tsx to run server.js - enables TypeScript imports for Prisma 7

68541c0

Fix db.js - add .ts extension for Prisma client import

50d0666

Use node --import tsx for better TypeScript support

f73b303

Fix start script to use tsx for Prisma 7 TypeScript support

b6c3954

Use dynamic import for autoSyncInit to avoid tsx caching issues

6bb9ed5

Add detailed logging for autoSyncInit dynamic import and function checks

8e22568

Add initializeRepositories to autoSyncInit.ts

43bafb6

MickLesk changed the title ~~tbd~~ Add TypeScript Runtime Support and Fix Prisma 7 Compatibility for Production Nov 28, 2025

Merge main into bugfixing_bumps - keep bugfixing_bumps versions (Pris…

e3af248

…ma 7, tsx support)

MickLesk added the feature label Nov 28, 2025

MickLesk marked this pull request as ready for review November 28, 2025 13:45

MickLesk requested a review from a team as a code owner November 28, 2025 13:45

MickLesk added 3 commits November 28, 2025 14:46

Update package-lock.json - add tsx to lock file

ba1e647

fix gh action

1c6d1ac

fix gh action runner

5bc3933

MickLesk changed the title ~~Add TypeScript Runtime Support and Fix Prisma 7 Compatibility for Production~~ Add TypeScript Runtime Support and add Prisma 7 Compatibility for Production Nov 28, 2025

MickLesk changed the title ~~Add TypeScript Runtime Support and add Prisma 7 Compatibility for Production~~ Add TypeScript Runtime Support and add Prisma 7 Compatibility Nov 28, 2025

michelroegl-brunner merged commit 0da802b into main Nov 28, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TypeScript Runtime Support and add Prisma 7 Compatibility#354

Add TypeScript Runtime Support and add Prisma 7 Compatibility#354
michelroegl-brunner merged 53 commits intomainfrom
bugfixing_bumps

MickLesk commented Nov 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MickLesk commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✍️ Description

📋 Changes Summary (30 Commits)

🔧 Core Infrastructure Changes

TypeScript Runtime Support

Module Resolution & Imports

🐛 Bug Fixes

Prisma 7 Compatibility

Server Initialization Issues

Service Module Exports

Dynamic Import Implementation

✨ Features & Improvements

Development Experience

Production Readiness

Type Safety

📝 Files Modified

🔍 Technical Details

What Was Wrong

How It Was Fixed

✅ Testing & Verification

📊 Commit Overview

🔗 Related Issues

✅ Prerequisites

🛠️ Type of Change

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MickLesk commented Nov 28, 2025 •

edited

Loading