fix: use node-specific Proxmox config paths for VM vs LXC (fixes #464)#479
Merged
michelroegl-brunner merged 1 commit intomainfrom Jan 29, 2026
Merged
fix: use node-specific Proxmox config paths for VM vs LXC (fixes #464)#479michelroegl-brunner merged 1 commit intomainfrom
michelroegl-brunner merged 1 commit intomainfrom
Conversation
- isVM(): check /etc/pve/nodes/<server.name>/qemu-server and lxc first, fallback to /etc/pve/qemu-server and lxc for single-node - checkConfigAndExtractInfo, config-existence checks, getContainerHostname, addClonedContainerToDatabase: use node-specific paths - syncLXCConfig/updateLXCConfig: use node-specific LXC config path - server.js clone flow: use node-specific config path Fixes #464
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes destroying LXC containers on multi-node Proxmox clusters where VM vs LXC detection used symlink paths that resolve to the wrong node.
Changes
/etc/pve/nodes/<server.name>/qemu-serverandlxcfirst; fall back to/etc/pve/qemu-serverand/etc/pve/lxcfor single-node setups.Issue
Closes #464 — Destroying container was failing with
Configuration file 'nodes/HP/qemu-server/168.conf' does not existbecause the container is LXC (config atnodes/HP/lxc/168.conf); the app was incorrectly runningqm destroyinstead ofpct destroydue to wrong-node path checks.