Upstream various patches from the migration and ROOT#188
Merged
aaronj0 merged 8 commits intocompiler-research:masterfrom Mar 30, 2026
Merged
Upstream various patches from the migration and ROOT#188aaronj0 merged 8 commits intocompiler-research:masterfrom
aaronj0 merged 8 commits intocompiler-research:masterfrom
Conversation
Reduce diff with ROOT
string-based CreateConverter already rejects mutable pointer references (T*&). Our forks should re-implement this in the type-based path.
The silent True/False return when comparing a null C++ pointer with None led to confusing behavior (x == None is True but x is None is False). Raise a TypeError with guidance to use truth value checks. Synced from ROOT commits 37581aa79ce and b337e97ed48.
Fixes Windows build where long long and intptr_t are incompatible. From the ROOT migration branch.
Use iterator-based construction to avoid implicit conversion issues between GetDimensions return type and dim_t on Windows. Synced from the ROOT migration branch
Collaborator
Author
|
The failing tests here are expected: We need to update the tests to no longer perform these unreliable checks |
This commit follows up on root-project/root@d35e114 wehere interfaces taking references to pointers were disallowed from being used in Python. That was a nice change, but we should continue to allow immutable references to pointers since that prevents pointer rebinding and can be used safely from Python. This commit enables the same and updates the `VoidPtrRefConverter` to map only to the const case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.