Fix number of processors environment variable Windows#277
Merged
vgvassilev merged 1 commit intocompiler-research:mainfrom May 10, 2024
Merged
Conversation
mcbarton
force-pushed
the
fix-number-of-processors-Windows
branch
from
39256a7 to
a72bc6b
Compare
mcbarton
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
===========================================
- Coverage 87.65% 75.45% -12.21%
===========================================
Files 4 8 +4
Lines 1742 2994 +1252
===========================================
+ Hits 1527 2259 +732
- Misses 215 735 +520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The envirnoment variable for the number of processors on Windows was previous not being calculated correctly, or outputted to the Github envirnoment. This means non of the Windows builds previously were building in parallel. This PR should fix this.