Skip to content

[ci] No longer do true for cppyy valgrind #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgvassilev merged 2 commits into from
May 15, 2024
Merged

[ci] No longer do true for cppyy valgrind #278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d220eb
[ci] No longer do true for cppyy valgrind
aaronj0 May 14, 2024
90a6754
Pull suppression file based on clang version
aaronj0 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,13 +1025,10 @@ jobs:
if [[ "${{ matrix.os }}" == macos-* ]]; then
echo "Skipping Valgrind checks on OS X"
else
if [[ "${{ matrix.clang-runtime }}" == "17" ]]; then
echo "Valgrind reports true for clang-runtime 17 due to problems with LLVM"
valgrind --show-error-list=yes --error-exitcode=1 --track-origins=yes --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v || true
else
echo "Running valgrind on passing tests"
valgrind --show-error-list=yes --error-exitcode=1 --track-origins=yes --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
fi
echo "Running valgrind on passing tests"
CLANG_VERSION="${{ matrix.clang-runtime }}"
SUPPRESSION_FILE="../etc/clang${CLANG_VERSION}-valgrind.supp"
valgrind --show-error-list=yes --error-exitcode=1 --track-origins=yes --suppressions="${SUPPRESSION_FILE}" --suppressions=../etc/valgrind-cppyy-cling.supp python -m pytest -m "not xfail" -v
fi
export RETCODE=+$?
echo ::endgroup::
Expand Down