Conversation
CMakeLists.txt
Outdated
| @@ -1,4 +1,9 @@ | |||
| cmake_minimum_required(VERSION 3.13) | |||
| set(CppInterOp_Version "1.4.0;dev") | |||
There was a problem hiding this comment.
We still need to read that from the file.
|
@mcbarton we have a failure on main(unittest/FunctionReflectionTest:Construct) which is also failing on the same commit that was passing earlier which leads me to believe we might need to rebuild the cache since the warnings PR did not build its own. would now be a good time or would you like to push more commits? |
|
@maximusron This PR is not ready. Rebuild the cache and I will revisit this PR tomorrow to fix the wasm jobs. |
|
Are we keeping the debug statements? |
The debug statements are not staying. They are just there because the PR is not currently working. I'm trying to work out why ;dev is still in the version name in the config file. |
|
@vgvassilev The debug run says this is doing what is expected. The ;dev in the version number in the config file is coming from somewhere else. Any ideas where? |
| @@ -1,4 +1,4 @@ | |||
| set(PACKAGE_VERSION "@CPPINTEROP_VERSION@") | |||
| set(PACKAGE_VERSION "@CPPINTEROP_VERSION_MAJOR@.@CPPINTEROP_VERSION_MINOR@.@CPPINTEROP_VERSION_PATCH@") | |||
There was a problem hiding this comment.
We need to signal if that came from a dev version or not somehow.
There was a problem hiding this comment.
I could have a variable contain the last thing in the version list. If it is the word dev then we could output a message to the screen telling the user that they are working with a dev version.
There was a problem hiding this comment.
On a second thought let's ignore this for now. Maybe we can keep track of this problem in a separate issue.
There was a problem hiding this comment.
We have managed to retain the ;dev part in package version in the end.
|
@mcbarton looks like this should be good to go now(based on the passing wasm builds). Let's rebase with main and squash before the last checks are done just to be sure |
@maximusron I think it is ok too. I've just done a cleanup of things I think are unneeded changes. Once the changes pass I will rebase. |
|
sounds good |
|
I'm going to cancel the run on main to speed this up |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 72.22% 72.22%
=======================================
Files 8 8
Lines 2963 2963
=======================================
Hits 2140 2140
Misses 823 823 |
|
@mcbarton can you rebase into a single commit before the checks? |
I will rebase it in around 1-2 hours time. I am away from my computer until then. |
3 participants
This PR will fix the broken wasm builds in the ci
Fixes #294