Fix git clang workflow os to Ubuntu 22.04#377
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
=======================================
Coverage 76.31% 76.31%
=======================================
Files 8 8
Lines 3137 3137
=======================================
Hits 2394 2394
Misses 743 743 |
Vipul-Cariappa
approved these changes
Dec 6, 2024
Collaborator
Vipul-Cariappa
left a comment
Vipul-Cariappa
left a comment
There was a problem hiding this comment.
Looks good to me.
I am curious, does this improve stability?
Looking at https://github.com/ZedThree/clang-tidy-review, they are using ubuntu-latest in the examples.
Collaborator
Author
|
@Vipul-Cariappa I don't think it makes it more stable. I just didn't want it to update to Ubuntu 24.04 and break. Ubuntu 22.04 is a known quantity. The plan is we won't be using that action soon as it's quite fragile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
The git clang workflow currently has a warning to see that soon the ubuntu-latest runners will default to Ubuntu 24.04 . To stop this I have fixed the version to Ubuntu 22.04 . This workflow will soon be replaced due to the workflow known to be fragile.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist