Fix emscripten build instructions#421
Merged
mcbarton merged 2 commits intocompiler-research:mainfrom Jan 10, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 70.85% 70.96% +0.10%
==========================================
Files 9 9
Lines 3538 3541 +3
==========================================
+ Hits 2507 2513 +6
+ Misses 1031 1028 -3 |
mcbarton
force-pushed
the
fix-build-instructions-xeus-cpp-lite
branch
from
07cc2f9 to
270dc6a
Compare
anutosh491
reviewed
Jan 10, 2025
Emscripten-build-instructions.md
Outdated
|
|
||
| We can move onto building the wasm version of CppInterOp. To do this execute the following | ||
| We can move onto building the wasm version of CppInterOp. We will do this within a Conda environment. We can achieve this | ||
| by execut (assumes you have micromamba installed and that your shell is initialised for the micromamba install) |
Collaborator
There was a problem hiding this comment.
Not sure what "by execut" means
Probably an overlook here ?
anutosh491
approved these changes
Jan 10, 2025
Collaborator
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
Looks good apart from the one comment I made.
Feel free to merge after fixing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This fixes the wasm build instructions. It matches what is done in #420
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist