Use Ninja to build llvm in the ci (osx and Ubuntu)#423
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Jan 9, 2025
Merged
Use Ninja to build llvm in the ci (osx and Ubuntu)#423mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton merged 1 commit intocompiler-research:mainfrom
Conversation
anutosh491
approved these changes
Jan 9, 2025
Collaborator
anutosh491
left a comment
There was a problem hiding this comment.
Thanks, I think this is nice. I would have also preferred ninja for the emscripten build but I remember there were some reasons why we switched from ninja to cmake on emscripten-forge. I guess we just had some trouble using ninja. I need to try again.
Having it on osx and ubuntu is a good start.
Collaborator
Author
|
@anutosh491 Ninja works now. I have tried it and plan to put in another PR for the emscripten build once the deployment PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
My local testing on an osx arm Macbook found an 35% reduction in the size of the build folder when using Ninja to build llvm. This should help reduce the pressure on the cache. Supposedly Ninja is faster so we should see a speed in the llvm build when we have to rebuild the cache. If the ci passes then all Ubuntu and MacOS builds should be cleared from the cache before merging.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist