Remove soname and zdefs flags emscripten build#446
Merged
mcbarton merged 4 commits intocompiler-research:mainfrom Jan 18, 2025
Merged
Remove soname and zdefs flags emscripten build#446mcbarton merged 4 commits intocompiler-research:mainfrom
mcbarton merged 4 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 70.96% 70.96%
=======================================
Files 9 9
Lines 3541 3541
=======================================
Hits 2513 2513
Misses 1028 1028 |
mcbarton
force-pushed
the
Remove-soname-of-zdefs-flags-emscripten
branch
3 times, most recently
from
9dbdcc3 to
61d9400
Compare
mcbarton
force-pushed
the
Remove-soname-of-zdefs-flags-emscripten
branch
from
1b441db to
362d304
Compare
vgvassilev
approved these changes
Jan 17, 2025
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM assuming we address the comments.
mcbarton
force-pushed
the
Remove-soname-of-zdefs-flags-emscripten
branch
from
613789e to
b862182
Compare
vgvassilev
reviewed
Jan 17, 2025
…hub.com/mcbarton/CppInterOp into Remove-soname-of-zdefs-flags-emscripten
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
When building the emscripten version of CppInterOp we get undefined linker flag soname and undefined z value warning here https://github.com/compiler-research/CppInterOp/actions/runs/12736895837/job/35497425197#step:9:213 . This PR should fix this.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist