Minor patches to unittests, improve offset initialization in getExecutionEngine#459
Merged
aaronj0 merged 2 commits intocompiler-research:mainfrom Jan 18, 2025
Merged
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
+ Coverage 71.04% 71.15% +0.11%
==========================================
Files 9 9
Lines 3550 3550
==========================================
+ Hits 2522 2526 +4
+ Misses 1028 1024 -4
... and 1 file with indirect coverage changes
|
vgvassilev
approved these changes
Jan 18, 2025
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
Please make clang-format happy
- Sets cmake environment property of CppInterOp unitests to LLVM include dir - Use cling::Declare instead of Process for include tests This hints towards a bug in cling::Process when we JIT two includes one after another like ``` std::string code = R"(#include <vector> \n #include <iostream>)" Interp->process(code);
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set of patches required on top of InterOp master for enabling ROOT, which can added upstream.