Includes must be in this order, windows.h first#599
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom May 28, 2025
Merged
Includes must be in this order, windows.h first#599mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton merged 1 commit intocompiler-research:mainfrom
Conversation
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 77.31% 77.31%
=======================================
Files 9 9
Lines 3685 3685
=======================================
Hits 2849 2849
Misses 836 836
🚀 New features to boost your workflow:
|
mcbarton
approved these changes
May 28, 2025
Collaborator
mcbarton
left a comment
mcbarton
left a comment
There was a problem hiding this comment.
LGTM! The Windows jobs pass the ci
Contributor
Author
|
I guess clang-format sometimes on windows is dangerous :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.