Skip to content

[ci] fix workflow names#620

Merged
aaronj0 merged 2 commits intocompiler-research:mainfrom
aaronj0:fix-ci-names
Jun 10, 2025
Merged

[ci] fix workflow names#620
aaronj0 merged 2 commits intocompiler-research:mainfrom
aaronj0:fix-ci-names

Conversation

@aaronj0
Copy link
Copy Markdown
Collaborator

@aaronj0 aaronj0 commented Jun 9, 2025

This PR should fix the issue of actions appearing as paths instead of names on the Github UI
The interpreter mode is now dynamically inserted (Cling/Clang-REPL) based on the config

before:
Screenshot from 2025-06-09 22-24-12

after:

Screenshot from 2025-06-09 22-22-47

@aaronj0 aaronj0 force-pushed the fix-ci-names branch 6 times, most recently from 69ee15c to 2f54e45 Compare June 9, 2025 20:07
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.66%. Comparing base (3d3c82d) to head (8b0887e).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #620   +/-   ##
=======================================
  Coverage   77.66%   77.66%           
=======================================
  Files           9        9           
  Lines        3743     3743           
=======================================
  Hits         2907     2907           
  Misses        836      836           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton
Copy link
Copy Markdown
Collaborator

mcbarton commented Jun 9, 2025

@aaronj0 This is quite a nice change. Could you make it add the cling version or clang repl/llvm version to the action name?

I know the purpose of this PR is to do with naming the reusable actions, but it might be nice to dynamically name the restore and save cache action names, based on whether its cling or clang-repl too.

@aaronj0
Copy link
Copy Markdown
Collaborator Author

aaronj0 commented Jun 10, 2025

@mcbarton I assume you meant something like:

Screenshot from 2025-06-10 14-13-20

which is the case with my latest changes

@mcbarton
Copy link
Copy Markdown
Collaborator

mcbarton commented Jun 10, 2025

@aaronj0 Yes that is what I meant. The only change that I would make now is to include the and word in the restore action, like you did with the llvm build, and save cache action (just for consistency). If you have a reason for omitting the word 'and' in the restore cache case, just let me know. I am happy to approve without that change, as its me just be nit-picky.

@aaronj0
Copy link
Copy Markdown
Collaborator Author

aaronj0 commented Jun 10, 2025

@aaronj0 Yes that is what I meant. The only change that I would make now is to include the and word in the restore action, like you did with the llvm build, and save cache action (just for consistency). If you have a reason for omitting the word 'and' in the restore cache case, just let me know. I am willing to approve without that change, as its me just be nit-picky.

Sure, that's being done now, you can can approve the PR now. I will merge it once the jobs pass and verifying that everything is functionally the same.

Copy link
Copy Markdown
Collaborator

@mcbarton mcbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aaronj0 . Merge once the ci passes.

@aaronj0 aaronj0 merged commit 730abc7 into compiler-research:main Jun 10, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants