Skip to content

[cmake] explicitly link against stdc++fs if GCC<9#794

Merged
aaronj0 merged 1 commit intocompiler-research:mainfrom
aaronj0:add-stdfs-gcc8
Feb 3, 2026
Merged

[cmake] explicitly link against stdc++fs if GCC<9#794
aaronj0 merged 1 commit intocompiler-research:mainfrom
aaronj0:add-stdfs-gcc8

Conversation

@aaronj0
Copy link
Copy Markdown
Collaborator

@aaronj0 aaronj0 commented Feb 3, 2026

Commmit 9d2f4c5 introduced a dependency on std::filesystem which requires explicit linker flags for GCC versions below 9 This fixes a build failure on Alma 8 jobs on ROOT's CI, which still uses GCC8.5

Commmit 9d2f4c5 introduced a dependency on `std::filesystem` which requires explicit linker flags for GCC versions below 9
This fixes a build failure on Alma 8 jobs on ROOT's CI, which still uses GCC8.5
@aaronj0 aaronj0 requested a review from vgvassilev February 3, 2026 11:24
Copy link
Copy Markdown
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.40%. Comparing base (af760d0) to head (2783760).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   79.40%   79.40%           
=======================================
  Files          11       11           
  Lines        3987     3987           
=======================================
  Hits         3166     3166           
  Misses        821      821           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aaronj0 aaronj0 merged commit 4cc7ff5 into compiler-research:main Feb 3, 2026
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants