Create CPPINTEROP_COMMON_WASM_TEST_COMPILE_FLAGS and CPPINTEROP_COMMON_WASM_TEST_LINK_FLAGS cmake variables to avoid repetition when creating tests#818
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Mar 21, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #818 +/- ##
=======================================
Coverage 79.75% 79.75%
=======================================
Files 11 11
Lines 4031 4031
=======================================
Hits 3215 3215
Misses 816 816 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
from
1666477 to
8fe0856
Compare
Collaborator
Author
|
This PR is ready for review |
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
from
8fe0856 to
e67d89e
Compare
Collaborator
Author
|
This PR is ready for review |
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
3 times, most recently
from
3fb3076 to
d326e63
Compare
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
2 times, most recently
from
9ea7100 to
fdb0f59
Compare
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
from
fdb0f59 to
ee98f1b
Compare
…N_WASM_TEST_LINK_FLAGS cmake variables to avoid repetition when creating tests
mcbarton
force-pushed
the
Avoid-duplication-compile-and-link-flags
branch
from
ee98f1b to
d503f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have multiple test suites, which have common compile and link options. Therefore this PR creates common compile and link flags to avoid repetition of these options in future when creating new test suites, and the need for changes in multiple places when changing these defaults in the future.