Fix read the docs developer documentation#824
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Mar 13, 2026
Merged
Fix read the docs developer documentation#824mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton merged 1 commit intocompiler-research:mainfrom
Conversation
Collaborator
Author
|
The developer documentation for this PR is working. See https://cppinterop--824.org.readthedocs.build/en/824/build/html/index.html |
mcbarton
force-pushed
the
Fix-developer-documentation
branch
from
409cdaa to
cc3e6f9
Compare
mcbarton
commented
Feb 25, 2026
| tools: | ||
| python: "3.11" | ||
| apt_packages: | ||
| - clang-18 |
Collaborator
Author
There was a problem hiding this comment.
I initially tried clang/llvm 21, but that wasn't available via apt on Ubuntu 24.04 . That is why I choose clang/llvm 20.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 11 11
Lines 4025 4025
=======================================
Hits 3209 3209
Misses 816 816 🚀 New features to boost your workflow:
|
mcbarton
changed the title
mcbarton
force-pushed
the
Fix-developer-documentation
branch
2 times, most recently
from
7bf7d0a to
317c1a2
Compare
mcbarton
force-pushed
the
Fix-developer-documentation
branch
2 times, most recently
from
73281de to
9e9da26
Compare
mcbarton
force-pushed
the
Fix-developer-documentation
branch
from
9e9da26 to
0849375
Compare
aaronj0
approved these changes
Mar 13, 2026
Collaborator
aaronj0
left a comment
aaronj0
left a comment
There was a problem hiding this comment.
LGTM, Thanks for catching this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you visit the developer documentation link in the readme you'll notice it is currently broken. This is because the read the docs config is currently set to use llvm 16 and for some reason llvm 18 was being installed despite trying to build with llvm 16 (given we haven't supported llvm 16 for a while means the read the docs developer documentation has been broken for a long time). This PR should fix everything by updating the docs build to reference an llvm 20 install.