fix error prone failure path in GetTypeFromScope#826
Merged
aaronj0 merged 1 commit intocompiler-research:mainfrom Mar 1, 2026
Merged
fix error prone failure path in GetTypeFromScope#826aaronj0 merged 1 commit intocompiler-research:mainfrom
GetTypeFromScope#826aaronj0 merged 1 commit intocompiler-research:mainfrom
Conversation
aaronj0
force-pushed
the
gettype-failure-path
branch
2 times, most recently
from
97725bd to
d178ffa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #826 +/- ##
=======================================
Coverage 79.56% 79.56%
=======================================
Files 11 11
Lines 4012 4013 +1
=======================================
+ Hits 3192 3193 +1
Misses 820 820
🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aaronj0
force-pushed
the
gettype-failure-path
branch
from
d178ffa to
6f4bf5f
Compare
aaronj0
force-pushed
the
gettype-failure-path
branch
from
6f4bf5f to
0553d80
Compare
The earlier path forced a cast to TypeDecl, which will assert if that's not a valid cast, eg. if you have a NamespaceDecl. ``` llvm/include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From*) [with To = clang::TypeDecl; From = clang::Decl]: Assertion `isa<To>(Val) && "cast<Ty>() argument of incompatible type!"' failed. ``` Allows for more flexible calls from cppyy, being less crash-prone. The old test has been extended.
aaronj0
force-pushed
the
gettype-failure-path
branch
from
0553d80 to
af012a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier path forced a cast to TypeDecl, which will assert if that's not a valid cast, eg. if you have a NamespaceDecl.
Allows for more flexible calls from cppyy, being less crash-prone. The old test has been extended.