Re: Adding API functions for detecting interpreter language and standard by keremsahn · Pull Request #839 · compiler-research/CppInterOp

keremsahn · 2026-03-05T18:53:15Z

Two API functions; InterpreterLanguage GetLanguage(), InterpreterLanguageStandard GetLanguageStandard() and enums for interpreter language, standard added.

Fixes #744

github-actions

clang-tidy made some suggestions

github-actions · 2026-03-06T08:35:01Z

include/clang-c/CXCppInterOp.h

+/**
+ * Enum to represent the programming language of the interpreter.
+ */
+typedef enum {


warning: enum 'CXInterpreterLanguage' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

typedef enum { ^

github-actions · 2026-03-06T08:35:02Z

include/clang-c/CXCppInterOp.h

+  CXInterpreterLanguage_CUDA,
+  CXInterpreterLanguage_HIP,
+  CXInterpreterLanguage_HLSL
+} CXInterpreterLanguage;


warning: use 'using' instead of 'typedef' [modernize-use-using]

Suggested change

} CXInterpreterLanguage;

using CXInterpreterLanguage = enum {

CXInterpreterLanguage_Unknown,

CXInterpreterLanguage_Asm,

CXInterpreterLanguage_CIR,

CXInterpreterLanguage_LLVM_IR,

CXInterpreterLanguage_C,

CXInterpreterLanguage_CPlusPlus,

CXInterpreterLanguage_ObjC,

CXInterpreterLanguage_ObjCPlusPlus,

CXInterpreterLanguage_OpenCL,

CXInterpreterLanguage_OpenCLCXX,

CXInterpreterLanguage_CUDA,

CXInterpreterLanguage_HIP,

CXInterpreterLanguage_HLSL

};

github-actions · 2026-03-06T08:35:02Z

include/clang-c/CXCppInterOp.h

+/**
+ * Enum to represent the language standard of the interpreter.
+ */
+typedef enum {


warning: enum 'CXInterpreterLanguageStandard' uses a larger base type ('unsigned int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size [performance-enum-size]

typedef enum { ^

github-actions · 2026-03-06T08:35:02Z

include/clang-c/CXCppInterOp.h

+  CXInterpreterLanguageStandard_hlsl202x,
+  CXInterpreterLanguageStandard_hlsl202y,
+  CXInterpreterLanguageStandard_lang_unspecified
+} CXInterpreterLanguageStandard;


warning: use 'using' instead of 'typedef' [modernize-use-using]

Suggested change

} CXInterpreterLanguageStandard;

using CXInterpreterLanguageStandard = enum {

CXInterpreterLanguageStandard_c89,

CXInterpreterLanguageStandard_c94,

CXInterpreterLanguageStandard_gnu89,

CXInterpreterLanguageStandard_c99,

CXInterpreterLanguageStandard_gnu99,

CXInterpreterLanguageStandard_c11,

CXInterpreterLanguageStandard_gnu11,

CXInterpreterLanguageStandard_c17,

CXInterpreterLanguageStandard_gnu17,

CXInterpreterLanguageStandard_c23,

CXInterpreterLanguageStandard_gnu23,

CXInterpreterLanguageStandard_c2y,

CXInterpreterLanguageStandard_gnu2y,

CXInterpreterLanguageStandard_cxx98,

CXInterpreterLanguageStandard_gnucxx98,

CXInterpreterLanguageStandard_cxx11,

CXInterpreterLanguageStandard_gnucxx11,

CXInterpreterLanguageStandard_cxx14,

CXInterpreterLanguageStandard_gnucxx14,

CXInterpreterLanguageStandard_cxx17,

CXInterpreterLanguageStandard_gnucxx17,

CXInterpreterLanguageStandard_cxx20,

CXInterpreterLanguageStandard_gnucxx20,

CXInterpreterLanguageStandard_cxx23,

CXInterpreterLanguageStandard_gnucxx23,

CXInterpreterLanguageStandard_cxx26,

CXInterpreterLanguageStandard_gnucxx26,

CXInterpreterLanguageStandard_opencl10,

CXInterpreterLanguageStandard_opencl11,

CXInterpreterLanguageStandard_opencl12,

CXInterpreterLanguageStandard_opencl20,

CXInterpreterLanguageStandard_opencl30,

CXInterpreterLanguageStandard_openclcpp10,

CXInterpreterLanguageStandard_openclcpp2021,

CXInterpreterLanguageStandard_hlsl,

CXInterpreterLanguageStandard_hlsl2015,

CXInterpreterLanguageStandard_hlsl2016,

CXInterpreterLanguageStandard_hlsl2017,

CXInterpreterLanguageStandard_hlsl2018,

CXInterpreterLanguageStandard_hlsl2021,

CXInterpreterLanguageStandard_hlsl202x,

CXInterpreterLanguageStandard_hlsl202y,

CXInterpreterLanguageStandard_lang_unspecified

};

lib/CppInterOp/CXCppInterOp.cpp

lib/CppInterOp/CppInterOp.cpp

codecov · 2026-03-06T20:12:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (795f450) to head (802d29a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #839      +/-   ##
==========================================
+ Coverage   79.56%   79.75%   +0.18%     
==========================================
  Files          11       11              
  Lines        4013     4035      +22     
==========================================
+ Hits         3193     3218      +25     
+ Misses        820      817       -3

Files with missing lines	Coverage Δ
include/CppInterOp/CppInterOp.h	`95.12% <ø> (ø)`
include/CppInterOp/Dispatch.h	`89.18% <ø> (ø)`
lib/CppInterOp/CXCppInterOp.cpp	`50.14% <100.00%> (+0.57%)`	⬆️
lib/CppInterOp/CppInterOp.cpp	`87.96% <100.00%> (+0.09%)`	⬆️

... and 1 file with indirect coverage changes

Files with missing lines	Coverage Δ
include/CppInterOp/CppInterOp.h	`95.12% <ø> (ø)`
include/CppInterOp/Dispatch.h	`89.18% <ø> (ø)`
lib/CppInterOp/CXCppInterOp.cpp	`50.14% <100.00%> (+0.57%)`	⬆️
lib/CppInterOp/CppInterOp.cpp	`87.96% <100.00%> (+0.09%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions

clang-tidy made some suggestions

lib/CppInterOp/CppInterOp.cpp

Vipul-Cariappa

Minor things

unittests/CppInterOp/InterpreterTest.cpp

lib/CppInterOp/CppInterOp.cpp

aaronj0

minor reordering

mcbarton

Can the tests we expanded to cover c23 and c++23? That way we cover all the standards we use for c/c++ kernels in xeus-cpp.

keremsahn · 2026-03-09T15:33:01Z

Can the tests we expanded to cover c23 and c++23? That way we cover all the standards we use for c/c++ kernels in xeus-cpp.

Sure, I will add one after this test session is completed

Vipul-Cariappa · 2026-03-10T07:53:11Z

@aaronj0, why do we have random cppyy tests failing?
The failing tests are not related to these changes.

github-actions

clang-tidy made some suggestions

github-actions · 2026-03-10T12:12:47Z

unittests/CppInterOp/InterpreterTest.cpp

+            Cpp::InterpreterLanguageStandard::gnucxx17);
+}
+
 TYPED_TEST(CPPINTEROP_TEST_MODE, Interpreter_ExternalInterpreter) {


warning: no header providing "llvm::ExitOnError" is directly included [misc-include-cleaner]

unittests/CppInterOp/InterpreterTest.cpp:2:

+ #include <llvm/Support/Error.h>

aaronj0 · 2026-03-11T07:20:16Z

@aaronj0, why do we have random cppyy tests failing? The failing tests are not related to these changes.

They have been fixed on main, rerunning should fix the jobs

review

aaronj0

LGTM

Vipul-Cariappa

LGTM!
Nice work. Thank you.

Vipul-Cariappa · 2026-03-12T08:38:48Z

Congratulations on your first PR to CppInterOp.

keremsahn · 2026-03-12T10:24:45Z

LGTM! Nice work. Thank you.

Thanks for guidance, I have learned a lot

mcbarton · 2026-03-24T14:55:49Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .

Here is the llvm 22 compatibility PR #812

keremsahn · 2026-03-24T16:31:13Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .

Here is the llvm 22 compatibility PR #812

I am checking

keremsahn · 2026-03-24T17:07:48Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .

Here is the llvm 22 compatibility PR #812

Check the llvm/llvm-project#148701
The problem is in:

    EXTERN_C void *memcpy(void *restrict dst, const void *restrict src, __SIZE_TYPE__ n);
    EXTERN_C inline void __clang_Interpreter_SetValueCopyArr(const void* Src, void* Placement, unsigned long Size) {
      memcpy(Placement, Src, Size);
    }

This is injected into the code and since the tests do not include c89 which restrict and inline keywords are not available the PR was not failed.

mcbarton · 2026-03-24T17:23:23Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .
Here is the llvm 22 compatibility PR #812

Check the llvm/llvm-project#148701 The problem is in:
    EXTERN_C void *memcpy(void *restrict dst, const void *restrict src, __SIZE_TYPE__ n);
    EXTERN_C inline void __clang_Interpreter_SetValueCopyArr(const void* Src, void* Placement, unsigned long Size) {
      memcpy(Placement, Src, Size);
    }
This is injected into the code and since the tests do not include c89 which restrict and inline keywords are not available the PR was not failed.

Thanks for the speedy reply. Do you have an idea for a patch which might fix the llvm 22 PR, either to CppInterOp or upstream in llvm?

keremsahn · 2026-03-24T17:49:25Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .
Here is the llvm 22 compatibility PR #812

Check the llvm/llvm-project#148701 The problem is in:
    EXTERN_C void *memcpy(void *restrict dst, const void *restrict src, __SIZE_TYPE__ n);
    EXTERN_C inline void __clang_Interpreter_SetValueCopyArr(const void* Src, void* Placement, unsigned long Size) {
      memcpy(Placement, Src, Size);
    }
This is injected into the code and since the tests do not include c89 which restrict and inline keywords are not available the PR was not failed.
Thanks for the speedy reply. Do you have an idea for a patch which might fix the llvm 22 PR, either to CppInterOp or upstream in llvm?

I think it is better to directly fix the original PR instead of a patch. We can use Clang extensions __restrict__ and __inline__ instead of actual keywords. I can create a PR regarding this but since I have midterms right now I may not be able to tackle with possible problems of PR so that it would slow down your llvm 22 integration.

Vipul-Cariappa · 2026-03-26T08:39:02Z

Not sure if I am replying too late. But we can just drop C89 test in CppInterOp. The inline function specifier was introduced in C99 (ref: https://en.cppreference.com/w/c/language/inline.html & https://en.cppreference.com/w/c/language/restrict.html). So let's just keep tests from C99.

@keremsahn could you please open an issue in LLVM about this incompatible code injection for C89 at interpreter startup. Please ping Vassil and me.

keremsahn · 2026-03-26T08:58:08Z

Not sure if I am replying too late. But we can just drop C89 test in CppInterOp. The inline function specifier was introduced in C99 (ref: https://en.cppreference.com/w/c/language/inline.html & https://en.cppreference.com/w/c/language/restrict.html). So let's just keep tests from C99.

@keremsahn could you please open an issue in LLVM about this incompatible code injection for C89 at interpreter startup. Please ping Vassil and me.

Tomorrow I will try the thing I suggested above, if it will not work it is just better to delete the C89 test as you said. And sure I will open the issue tonight or tomorrow.

keremsahn · 2026-03-27T18:59:08Z

Not sure if I am replying too late. But we can just drop C89 test in CppInterOp. The inline function specifier was introduced in C99 (ref: https://en.cppreference.com/w/c/language/inline.html & https://en.cppreference.com/w/c/language/restrict.html). So let's just keep tests from C99.

@keremsahn could you please open an issue in LLVM about this incompatible code injection for C89 at interpreter startup. Please ping Vassil and me.

Sorry about the delay, I were not available. llvm/llvm-project#189088 here is the issue. I will tackle with it tomorrow if it still remains unsolved.

keremsahn · 2026-03-30T19:40:12Z

@keremsahn I am currently trying to update CppInterOp to llvm 22. I am now down to one failing test (Interpreter_GetLanguageStandardC). As you added this test, I was wondering if you knew why I get this error for llvm 22 https://github.com/compiler-research/CppInterOp/actions/runs/23491010379/job/68359063882?pr=812#step:13:889 .

Here is the llvm 22 compatibility PR #812

The problem is solved but in the main branch, not in the release/22.x. Here is the PR llvm/llvm-project#189432

Vipul-Cariappa self-requested a review March 6, 2026 08:21

github-actions bot reviewed Mar 6, 2026

View reviewed changes

keremsahn force-pushed the lang-detection-fix branch from 69221b4 to 4fb2f71 Compare March 6, 2026 18:45

keremsahn marked this pull request as draft March 6, 2026 18:47

keremsahn force-pushed the lang-detection-fix branch from 4fb2f71 to 6853b9c Compare March 6, 2026 18:48

github-actions bot reviewed Mar 6, 2026

View reviewed changes

lib/CppInterOp/CppInterOp.cpp Outdated Show resolved Hide resolved

lib/CppInterOp/CppInterOp.cpp Outdated Show resolved Hide resolved

keremsahn marked this pull request as ready for review March 6, 2026 21:56

Vipul-Cariappa requested changes Mar 9, 2026

View reviewed changes

unittests/CppInterOp/InterpreterTest.cpp Outdated Show resolved Hide resolved

lib/CppInterOp/CppInterOp.cpp Outdated Show resolved Hide resolved

aaronj0 reviewed Mar 9, 2026

View reviewed changes

lib/CppInterOp/CppInterOp.cpp Show resolved Hide resolved

aaronj0 reviewed Mar 9, 2026

View reviewed changes

lib/CppInterOp/CppInterOp.cpp Outdated Show resolved Hide resolved

aaronj0 requested changes Mar 9, 2026

View reviewed changes

keremsahn force-pushed the lang-detection-fix branch from c39cc83 to 8c23c35 Compare March 9, 2026 12:50

keremsahn requested review from Vipul-Cariappa and aaronj0 March 9, 2026 12:51

mcbarton reviewed Mar 9, 2026

View reviewed changes

Vipul-Cariappa mentioned this pull request Mar 10, 2026

Error logs in console for the C kernel compiler-research/xeus-cpp#441

Closed

keremsahn force-pushed the lang-detection-fix branch from 8c23c35 to 6073fba Compare March 10, 2026 11:47

keremsahn requested a review from mcbarton March 10, 2026 11:48

keremsahn force-pushed the lang-detection-fix branch 2 times, most recently from 76c5871 to 6991527 Compare March 10, 2026 11:58

github-actions bot reviewed Mar 10, 2026

View reviewed changes

Add language detection support

802d29a

review

aaronj0 force-pushed the lang-detection-fix branch from 6991527 to 802d29a Compare March 11, 2026 07:57

aaronj0 approved these changes Mar 11, 2026

View reviewed changes

Vipul-Cariappa approved these changes Mar 12, 2026

View reviewed changes

Vipul-Cariappa merged commit a0d70b5 into compiler-research:main Mar 12, 2026
36 checks passed

keremsahn deleted the lang-detection-fix branch March 12, 2026 20:34

mcbarton mentioned this pull request Mar 25, 2026

Fix GetLanguage for CUDA/HIP where CXX standard was returned #870

Merged

-} CXInterpreterLanguage;
+using CXInterpreterLanguage = enum {
+  CXInterpreterLanguage_Unknown,
+  CXInterpreterLanguage_Asm,
+  CXInterpreterLanguage_CIR,
+  CXInterpreterLanguage_LLVM_IR,
+  CXInterpreterLanguage_C,
+  CXInterpreterLanguage_CPlusPlus,
+  CXInterpreterLanguage_ObjC,
+  CXInterpreterLanguage_ObjCPlusPlus,
+  CXInterpreterLanguage_OpenCL,
+  CXInterpreterLanguage_OpenCLCXX,
+  CXInterpreterLanguage_CUDA,
+  CXInterpreterLanguage_HIP,
+  CXInterpreterLanguage_HLSL
+};

-} CXInterpreterLanguageStandard;
+using CXInterpreterLanguageStandard = enum {
+  CXInterpreterLanguageStandard_c89,
+  CXInterpreterLanguageStandard_c94,
+  CXInterpreterLanguageStandard_gnu89,
+  CXInterpreterLanguageStandard_c99,
+  CXInterpreterLanguageStandard_gnu99,
+  CXInterpreterLanguageStandard_c11,
+  CXInterpreterLanguageStandard_gnu11,
+  CXInterpreterLanguageStandard_c17,
+  CXInterpreterLanguageStandard_gnu17,
+  CXInterpreterLanguageStandard_c23,
+  CXInterpreterLanguageStandard_gnu23,
+  CXInterpreterLanguageStandard_c2y,
+  CXInterpreterLanguageStandard_gnu2y,
+  CXInterpreterLanguageStandard_cxx98,
+  CXInterpreterLanguageStandard_gnucxx98,
+  CXInterpreterLanguageStandard_cxx11,
+  CXInterpreterLanguageStandard_gnucxx11,
+  CXInterpreterLanguageStandard_cxx14,
+  CXInterpreterLanguageStandard_gnucxx14,
+  CXInterpreterLanguageStandard_cxx17,
+  CXInterpreterLanguageStandard_gnucxx17,
+  CXInterpreterLanguageStandard_cxx20,
+  CXInterpreterLanguageStandard_gnucxx20,
+  CXInterpreterLanguageStandard_cxx23,
+  CXInterpreterLanguageStandard_gnucxx23,
+  CXInterpreterLanguageStandard_cxx26,
+  CXInterpreterLanguageStandard_gnucxx26,
+  CXInterpreterLanguageStandard_opencl10,
+  CXInterpreterLanguageStandard_opencl11,
+  CXInterpreterLanguageStandard_opencl12,
+  CXInterpreterLanguageStandard_opencl20,
+  CXInterpreterLanguageStandard_opencl30,
+  CXInterpreterLanguageStandard_openclcpp10,
+  CXInterpreterLanguageStandard_openclcpp2021,
+  CXInterpreterLanguageStandard_hlsl,
+  CXInterpreterLanguageStandard_hlsl2015,
+  CXInterpreterLanguageStandard_hlsl2016,
+  CXInterpreterLanguageStandard_hlsl2017,
+  CXInterpreterLanguageStandard_hlsl2018,
+  CXInterpreterLanguageStandard_hlsl2021,
+  CXInterpreterLanguageStandard_hlsl202x,
+  CXInterpreterLanguageStandard_hlsl202y,
+  CXInterpreterLanguageStandard_lang_unspecified
+};

Conversation

keremsahn commented Mar 5, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Vipul-Cariappa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aaronj0 left a comment

Choose a reason for hiding this comment

Uh oh!

mcbarton left a comment

Choose a reason for hiding this comment

Uh oh!

keremsahn commented Mar 9, 2026

Uh oh!

Vipul-Cariappa commented Mar 10, 2026

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

aaronj0 commented Mar 11, 2026

Uh oh!

aaronj0 left a comment

Choose a reason for hiding this comment

Uh oh!

Vipul-Cariappa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Vipul-Cariappa commented Mar 12, 2026

Uh oh!

keremsahn commented Mar 12, 2026

Uh oh!

mcbarton commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keremsahn commented Mar 24, 2026

Uh oh!

keremsahn commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcbarton commented Mar 24, 2026

Uh oh!

keremsahn commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vipul-Cariappa commented Mar 26, 2026

codecov bot commented Mar 6, 2026 •

edited

Loading

mcbarton commented Mar 24, 2026 •

edited

Loading

keremsahn commented Mar 24, 2026 •

edited

Loading

keremsahn commented Mar 24, 2026 •

edited

Loading