Skip to content

Remove restriction on xeus#845

Merged
aaronj0 merged 1 commit intocompiler-research:mainfrom
mcbarton:Remove-restriction-on-xeus
Mar 11, 2026
Merged

Remove restriction on xeus#845
aaronj0 merged 1 commit intocompiler-research:mainfrom
mcbarton:Remove-restriction-on-xeus

Conversation

@mcbarton
Copy link
Copy Markdown
Collaborator

@mcbarton mcbarton commented Mar 9, 2026

Now that the PR updating xeus-cpp to be compatible with xeus 6.0 has gone in, this PR is needed to make the Emscripten ci again.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.56%. Comparing base (852f6d4) to head (a146a0e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #845   +/-   ##
=======================================
  Coverage   79.56%   79.56%           
=======================================
  Files          11       11           
  Lines        4013     4013           
=======================================
  Hits         3193     3193           
  Misses        820      820           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton
Copy link
Copy Markdown
Collaborator Author

mcbarton commented Mar 9, 2026

@Vipul-Cariappa @aaronj0 This PR fixes the issue with the Emscripten ci on main, but something has happened to make jobs fail when running cppyy tests. I'll leave that issue for you 2 to sort out.

@mcbarton
Copy link
Copy Markdown
Collaborator Author

mcbarton commented Mar 9, 2026

The cppyy test failures are also happening for cppyys ci on main https://github.com/compiler-research/cppyy/actions/runs/22874491199

@aaronj0
Copy link
Copy Markdown
Collaborator

aaronj0 commented Mar 11, 2026

The cppyy test failures are also happening for cppyys ci on main https://github.com/compiler-research/cppyy/actions/runs/22874491199

Hi, the failures have been fixed so you can rerun and merge this PR once the checks are clear

edit: I have triggered a rerun

@mcbarton
Copy link
Copy Markdown
Collaborator Author

The cppyy test failures are also happening for cppyys ci on main https://github.com/compiler-research/cppyy/actions/runs/22874491199

Hi, the failures have been fixed so you can rerun and merge this PR once the checks are clear

edit: I have triggered a rerun

@aaronj0 I will be very busy today, so may not notice when it passes. Please merge for me if you see it has passed.

@aaronj0 aaronj0 merged commit 795f450 into compiler-research:main Mar 11, 2026
65 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants