Skip to content

include API after undef windows.h LoadLibrary#854

Merged
vgvassilev merged 1 commit intocompiler-research:mainfrom
aaronj0:fixloadlibraryundef
Mar 21, 2026
Merged

include API after undef windows.h LoadLibrary#854
vgvassilev merged 1 commit intocompiler-research:mainfrom
aaronj0:fixloadlibraryundef

Conversation

@aaronj0
Copy link
Copy Markdown
Collaborator

@aaronj0 aaronj0 commented Mar 13, 2026

We lose CppImpl::LoadLibrary otherwise, fixed an error on ROOT's Windows CI when using Dispatch to load the API

We lose `CppImpl::LoadLibrary` otherwise
@aaronj0 aaronj0 requested a review from vgvassilev March 13, 2026 14:25
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (a0d70b5) to head (2aa8427).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files          11       11           
  Lines        4035     4031    -4     
=======================================
- Hits         3218     3215    -3     
+ Misses        817      816    -1     
Files with missing lines Coverage Δ
include/CppInterOp/Dispatch.h 89.18% <ø> (ø)

... and 1 file with indirect coverage changes

Files with missing lines Coverage Δ
include/CppInterOp/Dispatch.h 89.18% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgvassilev vgvassilev merged commit 07c5776 into compiler-research:main Mar 21, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants