When Cpp::Declare is silent the API should retain the error code.#880
Open
vgvassilev wants to merge 2 commits intocompiler-research:mainfrom
Open
When Cpp::Declare is silent the API should retain the error code.#880vgvassilev wants to merge 2 commits intocompiler-research:mainfrom
vgvassilev wants to merge 2 commits intocompiler-research:mainfrom
Conversation
vgvassilev
added a commit
to vgvassilev/cppyy-backend
that referenced
this pull request
Mar 30, 2026
This patch resolves a fixme and requres compiler-research/CppInterOp#880
vgvassilev
added a commit
to compiler-research/cppyy-backend
that referenced
this pull request
Mar 30, 2026
This patch resolves a fixme and requres compiler-research/CppInterOp#880
aaronj0
added a commit
to aaronj0/root
that referenced
this pull request
Mar 30, 2026
vgvassilev
force-pushed
the
declare-ret-code
branch
from
2b1f48b to
41c5120
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
==========================================
+ Coverage 78.86% 79.09% +0.22%
==========================================
Files 11 11
Lines 4079 4090 +11
==========================================
+ Hits 3217 3235 +18
+ Misses 862 855 -7
🚀 New features to boost your workflow:
|
vgvassilev
force-pushed
the
declare-ret-code
branch
2 times, most recently
from
6d3c084 to
00b063e
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vgvassilev
force-pushed
the
declare-ret-code
branch
from
00b063e to
c80eaf7
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
Collaborator
|
@vgvassilev if your referring to the names not having -cppyy, even though they run cppyy, its just because the names were never updated. I noticed it the other day, but never put in a PR correcting it as you said to put a freeze on changes to the ci until its centralised. If you want that change then I can update this PR #873 and we can take those 2 minor changes in now. |
Collaborator
|
I've updated the job names in that linker PR with -cppyy where needed |
Collaborator
|
To fix the Emscripten jobs, you need to add the symbols its complaining about to https://github.com/vgvassilev/CppInterOp/blob/declare-ret-code/lib/CppInterOp/exports.ld |
vgvassilev
added a commit
to compiler-research/cppyy-backend
that referenced
this pull request
Apr 1, 2026
This patch resolves a fixme and requres compiler-research/CppInterOp#880
vgvassilev
added a commit
to compiler-research/cppyy-backend
that referenced
this pull request
Apr 1, 2026
This patch resolves a fixme and requres compiler-research/CppInterOp#880
vgvassilev
force-pushed
the
declare-ret-code
branch
from
a5e271d to
94d80eb
Compare
vgvassilev
force-pushed
the
declare-ret-code
branch
from
94d80eb to
a5e0193
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.