Skip to content

Improve the process initialization logic using function statics.#889

Merged
vgvassilev merged 1 commit intocompiler-research:mainfrom
vgvassilev:rework-init
Apr 5, 2026
Merged

Improve the process initialization logic using function statics.#889
vgvassilev merged 1 commit intocompiler-research:mainfrom
vgvassilev:rework-init

Conversation

@vgvassilev
Copy link
Copy Markdown
Contributor

This patch centralizes logically (but also lexically) the handling of the interpreter stack. We now have a single place where the global process initialization happens including initializing llvm.

This opens up the space for implementing crash handlers and diagnostic suppression.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@vgvassilev vgvassilev force-pushed the rework-init branch 2 times, most recently from 2e7468c to 16cdd95 Compare April 5, 2026 07:38
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2026

Codecov Report

❌ Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.93%. Comparing base (55d9654) to head (8375e73).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/CppInterOp/CppInterOp.cpp 89.79% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #889      +/-   ##
==========================================
+ Coverage   78.86%   78.93%   +0.06%     
==========================================
  Files          11       11              
  Lines        4083     4096      +13     
==========================================
+ Hits         3220     3233      +13     
  Misses        863      863              
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOpInterpreter.h 71.87% <ø> (-0.62%) ⬇️
lib/CppInterOp/CppInterOp.cpp 87.52% <89.79%> (+0.09%) ⬆️
Files with missing lines Coverage Δ
lib/CppInterOp/CppInterOpInterpreter.h 71.87% <ø> (-0.62%) ⬇️
lib/CppInterOp/CppInterOp.cpp 87.52% <89.79%> (+0.09%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

clang-tidy review says "All clean, LGTM! 👍"

This patch centralizes logically (but also lexically) the handling of the
interpreter stack. We now have a single place where the global process
initialization happens including initializing llvm.

This opens up the space for implementing crash handlers and diagnostic
suppression.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

clang-tidy review says "All clean, LGTM! 👍"

@vgvassilev vgvassilev merged commit f034fed into compiler-research:main Apr 5, 2026
33 checks passed
@vgvassilev vgvassilev deleted the rework-init branch April 5, 2026 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant