Simple identifiers do not require heavy parsing. NFC.#193
Open
vgvassilev wants to merge 1 commit intocompiler-research:masterfrom
Open
Simple identifiers do not require heavy parsing. NFC.#193vgvassilev wants to merge 1 commit intocompiler-research:masterfrom
vgvassilev wants to merge 1 commit intocompiler-research:masterfrom
Conversation
This patch checks if the interfaces are called with single identifiers and adds a fast path to regular CppInterOp lookup. It also checks for AST garbage that came from stringifying anonymous C++ entities. After these changes we should consume less memory and that will make our infrastructure more stable since it won't rely on interpreter's error recovery logic when a parsing fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch checks if the interfaces are called with single identifiers and adds a fast path to regular CppInterOp lookup. It also checks for AST garbage that came from stringifying anonymous C++ entities.
After these changes we should consume less memory and that will make our infrastructure more stable since it won't rely on interpreter's error recovery logic when a parsing fails.