Adapt to changes with CppInterOp Dispatch#172
Adapt to changes with CppInterOp Dispatch#172aaronj0 merged 6 commits intocompiler-research:masterfrom
Conversation
f7475f8 to
d860899
Compare
d860899 to
1c4a409
Compare
python/cppyy/__init__.py
Outdated
| """Declare C++ source <src> to Cling.""" | ||
| with _stderr_capture() as err: | ||
| errcode = gbl.Cpp.Declare(src) | ||
| errcode = gbl.Cpp.Declare(src, False) |
There was a problem hiding this comment.
Is there a way to provide a default argument? Eg Declare(src, X=False)?
There was a problem hiding this comment.
Yes, we never supported controlling verbosity with cppdef but this is a good chance to do so:
- def cppdef(src):
+ def cppdef(src, verbose = False):
"""Declare C++ source <src> to Cling."""
with _stderr_capture() as err:
- errcode = gbl.Cpp.Declare(src)
+ errcode = gbl.Cpp.Declare(src, not verbose)There was a problem hiding this comment.
Or did you mean just enumerating what False is and always passing it to gbl.Cpp.Declare?
78d38f4 to
493ace4
Compare
vgvassilev
left a comment
There was a problem hiding this comment.
Lgtm if the ci works as expected. Consider using squash on merge.
bb90b69 to
abb7726
Compare
|
@vgvassilev @aaronj0 Was it a failure of making the jobs pass that the llvm 18 jobs were dropped from the ci in this PR? |
With the new symbol dispatch approach, cppyy suffers from some issues on llvm18 on ubuntu. We can see that pattern on OS X as well. In an effort to make the CI happy again, we update the test tags and drop cppyy support for llvm18. I've opened the corresponding PR in CppInterOp here: compiler-research/CppInterOp#788 |
abb7726 to
8db43a1
Compare
8db43a1 to
541d4cf
Compare
|
Merging as the last CI run looked good. The recent force push refactored the changes into atomic commits |
No description provided.