Skip to content

Adapt to changes with CppInterOp Dispatch#172

Merged
aaronj0 merged 6 commits intocompiler-research:masterfrom
aaronj0:interop-dispatch
Jan 28, 2026
Merged

Adapt to changes with CppInterOp Dispatch#172
aaronj0 merged 6 commits intocompiler-research:masterfrom
aaronj0:interop-dispatch

Conversation

@aaronj0
Copy link
Copy Markdown
Collaborator

@aaronj0 aaronj0 commented Jan 24, 2026

No description provided.

"""Declare C++ source <src> to Cling."""
with _stderr_capture() as err:
errcode = gbl.Cpp.Declare(src)
errcode = gbl.Cpp.Declare(src, False)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to provide a default argument? Eg Declare(src, X=False)?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we never supported controlling verbosity with cppdef but this is a good chance to do so:

- def cppdef(src):
+ def cppdef(src, verbose = False):
    """Declare C++ source <src> to Cling."""
    with _stderr_capture() as err:
- errcode = gbl.Cpp.Declare(src)
+ errcode = gbl.Cpp.Declare(src, not verbose)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or did you mean just enumerating what False is and always passing it to gbl.Cpp.Declare?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either should work I think.

Copy link
Copy Markdown

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm if the ci works as expected. Consider using squash on merge.

@aaronj0 aaronj0 force-pushed the interop-dispatch branch 2 times, most recently from bb90b69 to abb7726 Compare January 27, 2026 19:09
@mcbarton
Copy link
Copy Markdown
Collaborator

mcbarton commented Jan 28, 2026

@vgvassilev @aaronj0 Was it a failure of making the jobs pass that the llvm 18 jobs were dropped from the ci in this PR?

@aaronj0
Copy link
Copy Markdown
Collaborator Author

aaronj0 commented Jan 28, 2026

@vgvassilev @aaronj0 Was it a failure of making the jobs pass that the llvm 18 jobs were dropped from the ci in this PR?

With the new symbol dispatch approach, cppyy suffers from some issues on llvm18 on ubuntu. We can see that pattern on OS X as well. In an effort to make the CI happy again, we update the test tags and drop cppyy support for llvm18. I've opened the corresponding PR in CppInterOp here: compiler-research/CppInterOp#788

@aaronj0
Copy link
Copy Markdown
Collaborator Author

aaronj0 commented Jan 28, 2026

Merging as the last CI run looked good. The recent force push refactored the changes into atomic commits

@aaronj0 aaronj0 merged commit eebef45 into compiler-research:master Jan 28, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants