Add tests for xmagics, os, xutils, xinterpreter#116
Add tests for xmagics, os, xutils, xinterpreter#116vgvassilev merged 1 commit intocompiler-research:mainfrom
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
sys/wait.h is for unix systems only. You will need a different header for Windows. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
unistd.h is also unix only. |
|
@mcbarton the handler function which has |
|
@tharun571 Maybe you could try one of the suggestions from this stackoverflow page where they talk about Windows equivalents https://stackoverflow.com/questions/341817/is-there-a-replacement-for-unistd-h-for-windows-visual-c . |
|
Also is there a way to check windows build in local? or should I push the code everytime to check? |
If you have access to a Windows machine you could run the commands in the ci. There are currently no Windows instructions in the documentation. I will add at some point. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Converting to draft, let us know when the PR is ready for review (after maybe squashing the commits too) |
|
@anutosh491 this covers most of #114. Having some trouble with complete_request. Will push that later. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
left a comment
There was a problem hiding this comment.
Looks good. Let's wait for maybe one more review before we merge this.
cc @mcbarton
No description provided.