Add tests for xmagics#138
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 75.08% 79.31% +4.22%
==========================================
Files 17 17
Lines 602 609 +7
Branches 59 59
==========================================
+ Hits 452 483 +31
+ Misses 150 126 -24 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
test/test_interpreter.cpp
Outdated
| /** | ||
| * @class StreamRedirectRAII | ||
| * @brief A RAII class to redirect a stream to a stringstream. | ||
| * | ||
| * This class redirects the output of a given std::ostream to a std::stringstream. | ||
| * The original stream is restored when the object is destroyed. | ||
| */ |
There was a problem hiding this comment.
| /** | |
| * @class StreamRedirectRAII | |
| * @brief A RAII class to redirect a stream to a stringstream. | |
| * | |
| * This class redirects the output of a given std::ostream to a std::stringstream. | |
| * The original stream is restored when the object is destroyed. | |
| */ | |
| /// A RAII class to redirect a stream to a stringstream. | |
| /// | |
| /// This class redirects the output of a given std::ostream to a std::stringstream. | |
| /// The original stream is restored when the object is destroyed. |
There was a problem hiding this comment.
I've been used to this style of doxygen comments from llvm. Probably easier when building doxygen documentation one day in terms of configuration, etc. I did not find a lot of API documentation in the xeus-cpp, so maybe we should establish that style here...
test/test_interpreter.cpp
Outdated
| } | ||
|
|
||
| private: | ||
| std::streambuf* old_stream_buff; ///< The original buffer of the stream. |
There was a problem hiding this comment.
| std::streambuf* old_stream_buff; ///< The original buffer of the stream. | |
| /// The original buffer of the stream. | |
| std::streambuf* old_stream_buff; |
Documenting the public api is generally enough as the expectation is that the private api will vary over time more and will more likely cause the documentation to go out of sync.
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
No description provided.