Added functions to retrieve tag files/configs#143
Merged
vgvassilev merged 2 commits intocompiler-research:mainfrom Jun 18, 2024
Merged
Added functions to retrieve tag files/configs#143vgvassilev merged 2 commits intocompiler-research:mainfrom
vgvassilev merged 2 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 82.05% 82.13% +0.08%
==========================================
Files 17 17
Lines 613 627 +14
Branches 59 61 +2
==========================================
+ Hits 503 515 +12
- Misses 110 112 +2
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
JohanMabille
approved these changes
Jun 18, 2024
Collaborator
JohanMabille
left a comment
JohanMabille
left a comment
There was a problem hiding this comment.
LGTM. Next setp will be to restore the old config file, i.e. not gernerating it from cmake, but read the version from it in the CMakeLists.txt instead. This can be done in a dedicated PR.
Collaborator
Author
|
Thanks @JohanMabille for the review. Let's go ahead and merge this. I'll try to quickly address the above TODO in a dedicated PR :) |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
This PR would probably be worth porting to xeus-cling. |
Collaborator
Author
|
Sure I can look into it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
We should be dependent on compile time definitions for fetching tagfiles and we should be using prefix_path from xeus to do the following at runtime as mentioned in the issue. Hence I've added relevant functions in the xutils.hpp file for the same.
Fixes #54
Type of change
Please tick all options which are relevant.