XAssist - add model freedom and ollama support#156
XAssist - add model freedom and ollama support#156vgvassilev merged 1 commit intocompiler-research:mainfrom
Conversation
|
The failing CI (installing mamba/ micromamba) is due to the new release Let's do this for now, untill the issue is fixed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 81.97% 75.26% -6.71%
==========================================
Files 19 19
Lines 760 837 +77
Branches 79 91 +12
==========================================
+ Hits 623 630 +7
- Misses 137 207 +70
|
| std::cerr << "Failed to open file for reading URL for model " << model << std::endl; | ||
| return ""; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Technically any utility function like these should be tested for (either in test_interpreter.cpp itself or maybe through a test_utils.cpp if possible)
But that can be done through subsequent PRs (an issue can be opened to track the same) !
anutosh491
left a comment
There was a problem hiding this comment.
Clang-tidy reviews should be addressed. Apart from that it LGTM.
I would just wait for the green flag by @vgvassilev before merging !
1de9a78 to
e28d80a
Compare
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM, let's ignore the infrastructure issue of the clang-tidy bot.
Description
Type of change
Please tick all options which are relevant.