Fix retrieve_tagconf_dir and retrieve_tagfile_dir functions#228
Merged
Fix retrieve_tagconf_dir and retrieve_tagfile_dir functions#228
Conversation
Collaborator
Author
|
As simple cout statements here can show Lines 125 to 126 in 53d2f64 That the paths we are using are wrong. We just got lucky here as I think as only the last bit of the file path is being used. |
f3e0591 to
fc3943d
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
fc3943d to
e99c79a
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187
🚀 New features to boost your workflow:
|
mcbarton
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Please include a summary of changes, motivation and context for this PR.
Type of change
Please tick all options which are relevant.