Update xeus-cpp-lite to use emsdk 3.1.73#246
Merged
anutosh491 merged 1 commit intocompiler-research:mainfrom Jan 29, 2025
Merged
Update xeus-cpp-lite to use emsdk 3.1.73#246anutosh491 merged 1 commit intocompiler-research:mainfrom
anutosh491 merged 1 commit intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 80.72% 80.72%
=======================================
Files 19 19
Lines 970 970
Branches 93 93
=======================================
Hits 783 783
Misses 187 187 |
Collaborator
Author
|
That we use jupyterlite 0.5.0 yet, we need to use 0.5.1 here ! Needs a jupyterlite feedstock update otherwise Raised a PR here conda-forge/jupyterlite-core-feedstock#48 |
Collaborator
Author
|
Closing and Reopening to re-run jobs |
martinRenou
approved these changes
Jan 29, 2025
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Just a question. Otherwise looks good!
This was referenced Jan 29, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Completes the update to 3.1.73 !
Type of change
Please tick all options which are relevant.