Fix extract_filename function#25
Merged
anutosh491 merged 1 commit intocompiler-research:mainfrom Jan 18, 2024
Merged
Conversation
JohanMabille
requested changes
Jan 12, 2024
anutosh491
force-pushed
the
fix_extract_filename
branch
from
457dc36 to
5017a97
Compare
JohanMabille
approved these changes
Jan 16, 2024
vgvassilev
reviewed
Jan 17, 2024
2) Added test for extract_filename function
vgvassilev
reviewed
Jan 18, 2024
anutosh491
force-pushed
the
fix_extract_filename
branch
from
ea733d9 to
d740f86
Compare
vgvassilev
approved these changes
Jan 18, 2024
Contributor
vgvassilev
left a comment
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM assuming my comment will be addressed in a subsequent PR.
Collaborator
Author
|
Sure, thanks for the reviews. Now that I have approvals on this, let's merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
extract_filenamefunction is going to be editingargv, then it also needs to make a corresponding change toargc. Can lead to inconsistencies otherwise.