Install graphviz docs environment.yml#274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 80.56% 80.56%
=======================================
Files 20 20
Lines 957 957
Branches 88 88
=======================================
Hits 771 771
Misses 186 186 🚀 New features to boost your workflow:
|
d49e3d9 to
5acef3e
Compare
|
@anutosh491 @JohanMabille @vgvassilev pinging for review. |
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM, however, I am wondering if there is some way to say this is a dependency only for the documentation -- I do not see how but would have been good to be able to express that...
This is only added as a dependency of the documentation already. You cannot build the documentation as part of the cmake build process. If you look at the file I edited you'll see that it is a environment file just for the docs folder. |
Merging, as been approved, and the question about adding as a documentation dependency is what we are already doing. |
Description
Please include a summary of changes, motivation and context for this PR.
If you visit the xeus-cpp read the docs build log here https://readthedocs.org/projects/xeus-cpp/builds/27398561/ you'll see many errors about dot not being found and not being able to do certain things. This is fixed if you install Graphviz like it mentions later on in the logs.
Fixes # (issue)
Type of change
Please tick all options which are relevant.