Disable xsystem for WASM#288
Merged
anutosh491 merged 2 commits intocompiler-research:mainfrom Apr 19, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 82.15% 82.15%
=======================================
Files 20 20
Lines 958 958
Branches 88 88
=======================================
Hits 787 787
Misses 171 171 🚀 New features to boost your workflow:
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
reviewed
Apr 17, 2025
tharun571
force-pushed
the
wasm
branch
3 times, most recently
from
5416e4c to
9fd5a85
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
reviewed
Apr 17, 2025
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
anutosh491
approved these changes
Apr 19, 2025
Collaborator
anutosh491
left a comment
anutosh491
left a comment
There was a problem hiding this comment.
Looks good.
This is not expected to work for the wasm build (so its not that it fails, it just isn't expected to work .... Can we make that a bit more clear in the PR description ?) !!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shell commands do not work in WASM environment. This PR disables it.
Type of change
Please tick all options which are relevant.