Set minimum required xeus-lite version to 3.2.1#339
Merged
SylvainCorlay merged 2 commits intocompiler-research:mainfrom Jun 6, 2025
Merged
Set minimum required xeus-lite version to 3.2.1#339SylvainCorlay merged 2 commits intocompiler-research:mainfrom
SylvainCorlay merged 2 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #339 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Set-minimum-xeus-lite-cmake
branch
from
964abe2 to
76d0934
Compare
mcbarton
force-pushed
the
Set-minimum-xeus-lite-cmake
branch
from
12471f4 to
7a9fc12
Compare
SylvainCorlay
approved these changes
Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
If you look at Emscripten xeus-cpp recipe in Emscripten forge here https://github.com/emscripten-forge/recipes/blob/b34db3abcffbec2b24b97d4fd8def6c4d31888e4/recipes/recipes_emscripten/xeus-cpp/recipe.yaml#L22C19-L22C24 , it has a minimum version of xeus-lite of 3.2.1. This PR makes it is so that cmake also has this minimum required version
Fixes # (issue)
Type of change
Please tick all options which are relevant.