Combine configure_native_kernel and configure_wasm_kernel functions into configure_kernel function#359
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Aug 11, 2025
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 82.10% 81.78% -0.32%
==========================================
Files 20 20
Lines 950 950
Branches 87 87
==========================================
- Hits 780 777 -3
- Misses 170 173 +3 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
combine-configure-kernel-functions-cmake
branch
from
f0bf779 to
db2fbfc
Compare
mcbarton
force-pushed
the
combine-configure-kernel-functions-cmake
branch
from
db2fbfc to
3666020
Compare
…nto configure_kernel function
mcbarton
force-pushed
the
combine-configure-kernel-functions-cmake
branch
from
3666020 to
e49f42b
Compare
Collaborator
Author
|
@SylvainCorlay @anutosh491 @vgvassilev pinging for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
To avoid repetition in xeus-cpp cmake, this PR combines configure_native_kernel and configure_wasm_kernel functions into a single configure_kernel function.
Fixes # (issue)
Type of change
Please tick all options which are relevant.