Run browser tests in safari#368
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 82.10% 81.78% -0.32%
==========================================
Files 20 20
Lines 950 950
Branches 87 87
==========================================
- Hits 780 777 -3
- Misses 170 173 +3 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
5efac06 to
88566ee
Compare
vgvassilev
left a comment
There was a problem hiding this comment.
Cool that we can run now tests in Safari too. Does it fail if something is broken?
@vgvassilev Yes it will fail if something is broken, because emrun will catch the non zero exit code, just like the other browsers. Selenium and safaridriver are just used to open the webpage in Safari, then emrun gets the output from the tests running (including the return value). |
88566ee to
34e8bf8
Compare
|
I will update this PR soon to use the relative path to safari test script to be consistent with what cppinterop does |
f82d694 to
2f902c9
Compare
2f902c9 to
adcf86a
Compare
Description
Please include a summary of changes, motivation and context for this PR.
Fixes # (issue)
Type of change
Please tick all options which are relevant.