Run kernel tests for all c++ kernels#384
Merged
mcbarton merged 1 commit intocompiler-research:mainfrom Oct 9, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
Collaborator
Author
|
This PR can almost certainly be done in fewer lines. Python is not my strong suit, and I've just done it in a way which was clear to me. |
140f1d2 to
0a76d4b
Compare
Collaborator
Author
|
@JohanMabille pinging for review The purpose of this PR is to make it so that all the c++ kernels are tested. Currently only 1 is tested. In future PRs I plan to expand this to test the new c kernels too. With xeus-cpp about to get debug kernels too, its useful that it has a mechanism to run test sets for multiple kernels. |
JohanMabille
approved these changes
Oct 9, 2025
Collaborator
|
Awesome! Testing all the available kernels is something I should have done earlier, thanks for fixing it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
This PR is part of a series of PRs to improve the testing of xeus-cpp kernels. The purpose of this first PR is to run the python kernel tests for all c++ kernels and not just a single kernel (currently xcpp20).
Fixes # (issue)
Type of change
Please tick all options which are relevant.