Drop smallpt example notebook#422
Merged
JohanMabille merged 1 commit intocompiler-research:mainfrom Dec 1, 2025
Merged
Conversation
Collaborator
|
Drop all the SDL changes from Cmake too I guess! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 81.94% 81.94%
=======================================
Files 21 21
Lines 853 853
Branches 87 87
=======================================
Hits 699 699
Misses 154 154 🚀 New features to boost your workflow:
|
925a065 to
4cf68cb
Compare
4cf68cb to
7042815
Compare
Collaborator
Author
I did wonder whether to do this. I have done this now. |
JohanMabille
approved these changes
Dec 1, 2025
Collaborator
|
Thanks, I can add a better ray tracer example soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this comment #415 (comment) and on Discord @anutosh491 mentioned that the smallpt example isn't really adding much value to the repo, and is likely to be dropped before the next release. This PR removes the smallpt notebook from the repo, and any reference to it in the documentation.