Catch node failures in ci#446
Merged
SylvainCorlay merged 1 commit intocompiler-research:mainfrom Feb 18, 2026
Merged
Conversation
Collaborator
Author
|
Node failures now being caught with |
2667d86 to
02b11ff
Compare
90d742f to
4256df6
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 21 21
Lines 864 864
Branches 78 78
=======================================
Hits 702 702
Misses 162 162 🚀 New features to boost your workflow:
|
4256df6 to
173ac09
Compare
Collaborator
Author
|
@anutosh491 @SylvainCorlay @vgvassilev pinging for review. Without this change we cannot pick up failures of the Emscripten tests when they are run within node. See the PR description for a recent example where we didn't pick up the failure in the tests running in node (luckily we had the browser tests fail). |
Collaborator
|
This looks good to me. |
SylvainCorlay
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we was experimenting with reducing the initial memory when creating the xeus-cpp tests, the node tests failed to run, but the ci didn't catch it and fail (see https://github.com/compiler-research/xeus-cpp/actions/runs/21941897688/job/63369501220#step:5:182). This PR will attempt to catch these failures, and once they are caught the cmake change will be reverted.