Skip to content

Catch node failures in ci#446

Merged
SylvainCorlay merged 1 commit intocompiler-research:mainfrom
mcbarton:catch-node-failures
Feb 18, 2026
Merged

Catch node failures in ci#446
SylvainCorlay merged 1 commit intocompiler-research:mainfrom
mcbarton:catch-node-failures

Conversation

@mcbarton
Copy link
Collaborator

When we was experimenting with reducing the initial memory when creating the xeus-cpp tests, the node tests failed to run, but the ci didn't catch it and fail (see https://github.com/compiler-research/xeus-cpp/actions/runs/21941897688/job/63369501220#step:5:182). This PR will attempt to catch these failures, and once they are caught the cmake change will be reverted.

@mcbarton
Copy link
Collaborator Author

@mcbarton mcbarton force-pushed the catch-node-failures branch 2 times, most recently from 2667d86 to 02b11ff Compare February 17, 2026 10:09
@mcbarton mcbarton marked this pull request as ready for review February 17, 2026 10:09
@mcbarton mcbarton force-pushed the catch-node-failures branch 2 times, most recently from 90d742f to 4256df6 Compare February 17, 2026 10:50
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (b29ea88) to head (173ac09).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          21       21           
  Lines         864      864           
  Branches       78       78           
=======================================
  Hits          702      702           
  Misses        162      162           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton force-pushed the catch-node-failures branch from 4256df6 to 173ac09 Compare February 18, 2026 07:52
@mcbarton
Copy link
Collaborator Author

@anutosh491 @SylvainCorlay @vgvassilev pinging for review. Without this change we cannot pick up failures of the Emscripten tests when they are run within node. See the PR description for a recent example where we didn't pick up the failure in the tests running in node (luckily we had the browser tests fail).

@SylvainCorlay
Copy link
Collaborator

This looks good to me.

@SylvainCorlay SylvainCorlay merged commit 72b0a32 into compiler-research:main Feb 18, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants