Skip to content

Replaced adhoc build of reply with helpers#457

Merged
JohanMabille merged 1 commit intocompiler-research:mainfrom
JohanMabille:helpers
Mar 11, 2026
Merged

Replaced adhoc build of reply with helpers#457
JohanMabille merged 1 commit intocompiler-research:mainfrom
JohanMabille:helpers

Conversation

@JohanMabille
Copy link
Collaborator

Foollow up of #453

@JohanMabille JohanMabille requested a review from mcbarton March 11, 2026 14:17
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.28%. Comparing base (ff0a307) to head (807512d).

Files with missing lines Patch % Lines
src/xinspect.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
- Coverage   80.67%   80.28%   -0.40%     
==========================================
  Files          21       21              
  Lines         859      847      -12     
  Branches       78       78              
==========================================
- Hits          693      680      -13     
- Misses        166      167       +1     
Files with missing lines Coverage Δ
src/xinterpreter.cpp 88.07% <100.00%> (-0.95%) ⬇️
src/xinspect.cpp 91.89% <0.00%> (-0.84%) ⬇️
Files with missing lines Coverage Δ
src/xinterpreter.cpp 88.07% <100.00%> (-0.95%) ⬇️
src/xinspect.cpp 91.89% <0.00%> (-0.84%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@JohanMabille JohanMabille changed the title Replaced ahoc build of reply with helpers Replaced adhoc build of reply with helpers Mar 11, 2026
Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I always end up thinking if we could somehow mention both C++ & C in the language_info:name field but it's okay 😅

@JohanMabille JohanMabille merged commit 5d57832 into compiler-research:main Mar 11, 2026
30 of 31 checks passed
@JohanMabille JohanMabille deleted the helpers branch March 11, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants