[requires CppInterOp 1.9.0 release] Use Cpp::GetLanguage to set language#462
Draft
mcbarton wants to merge 1 commit intocompiler-research:mainfrom
Draft
[requires CppInterOp 1.9.0 release] Use Cpp::GetLanguage to set language#462mcbarton wants to merge 1 commit intocompiler-research:mainfrom
mcbarton wants to merge 1 commit intocompiler-research:mainfrom
Conversation
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
from
d1c8afa to
be511a4
Compare
mcbarton
force-pushed
the
detect-language-via-cppinterop
branch
from
da90ecb to
1c47973
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| //NOLINTNEXTLINE (cppcoreguidelines-pro-bounds-pointer-arithmetic) | ||
| createInterpreter(Args(argv ? argv + 1 : argv, argv + argc)); | ||
| m_version = get_stdopt(); | ||
| m_language = Cpp::GetLanguage(nullptr); |
Contributor
There was a problem hiding this comment.
warning: 'm_language' should be initialized in a member initializer of the constructor [cppcoreguidelines-prefer-member-initializer]
src/xinterpreter.cpp:105:
- xmagics()
+ m_language(GetLanguage(nullptr)), xmagics()
Suggested change
| m_language = Cpp::GetLanguage(nullptr); | |
| //NOLINTNEXTLINE (cppcoreguidelines-pro-bounds-pointer-arithmetic) | ||
| createInterpreter(Args(argv ? argv + 1 : argv, argv + argc)); | ||
| m_version = get_stdopt(); | ||
| m_language = Cpp::GetLanguage(nullptr); |
Contributor
There was a problem hiding this comment.
warning: no member named 'GetLanguage' in namespace 'CppImpl' [clang-diagnostic-error]
m_language = Cpp::GetLanguage(nullptr);
^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With CppInterOp 1.9.0, an API was created which can detect the language of the interpreter (Cpp::GetLanguage). This PR uses this API to set the language, rather than it being static to C++, which will be incorrect for the C kernels. This PR needs testing and I will check it in the coming days.