Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
+ Coverage 51.60% 52.42% +0.81%
==========================================
Files 15 15
Lines 593 599 +6
==========================================
+ Hits 306 314 +8
+ Misses 287 285 -2 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
CMakeLists.txt
Outdated
| configure_kernel("share/jupyter/kernels/xcpp11") | ||
| configure_kernel("share/jupyter/kernels/xcpp14") | ||
| configure_kernel("share/jupyter/kernels/xcpp17") | ||
| configure_kernel("share/jupyter/kernels/xcpp17-omp") |
There was a problem hiding this comment.
I am not sure I understand how this works. We need to pass somehow -fopenmp as a flag. XEUS_CPP_OMP probably does not expand to anything...
There was a problem hiding this comment.
I'll remove adding the omp-17 kernel and move that to a different PR. I assumed that infrastructure was there to use it, but had accidentally been missed. I'll leave this PR to just adding the c++20 kernel.
There was a problem hiding this comment.
I'll remove adding the omp-17 kernel and move that to a different PR. I assumed that infrastructure was there to use it, but had accidentally been missed. I'll leave this PR to just adding the c++20 kernel.
@vgvassilev I've made this change now, so the PR should hopefully be ok to merge now.
d1b646c to
dd506c4
Compare
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM. I'd wait for @JohanMabille.
The purpose of this PR is to add a c++20 kernel.