Fix it so jupyter_kernel_test runs without error on Windows#92
Closed
mcbarton wants to merge 37 commits intocompiler-research:mainfrom
Closed
Fix it so jupyter_kernel_test runs without error on Windows#92mcbarton wants to merge 37 commits intocompiler-research:mainfrom
mcbarton wants to merge 37 commits intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 53.66% 53.66%
=======================================
Files 15 15
Lines 600 600
=======================================
Hits 322 322
Misses 278 278 |
Collaborator
Author
|
The issue appears to be that when running the python tests on Windows that the kernel json cannot be parsed in order to do the tests if I read the output correctly. I will investigate. |
mcbarton
force-pushed
the
Fix-Windows-tests
branch
from
aa6daa0 to
36f4c1f
Compare
Collaborator
Author
|
Tests are now running. Just need to work out why they are failing. |
mcbarton
changed the title
Collaborator
Author
|
@JohanMabille @vgvassilev @alexander-penev can you review this PR? It makes changes such that the kernels can be parsed on Windows for jupyter_kernel_test , so they can now run. I have stopped the failing tests from running on Windows, and raised it as an issue here #95. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will make it so the jupyter kernel tests can run on Windows.