Add repo field to AcquireLockRequest and remove unused RPCs#30
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new repo identifier to the orchestrator JobRequest protobuf so job submissions can carry a repository name, enabling repo-aware job history display in downstream dashboards.
Changes:
- Add
string repo = 5toJobRequestinproto/orchestrator/orchestrator.proto.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Jobs flow through the lock acquire/release cycle, not SubmitJob. The proxy passes repo from its HTTP API to the orchestrator via gRPC.
compscidr
changed the title
All device interaction now flows through the lock-based model. Remove 7 dead RPCs and their message types: - SubmitJob, GetJobStatus, JobRequest, JobOutput, JobState, JobStatusRequest, JobStatus, DeviceRequirements - AcquireDevice, ExecuteOnSession, ReleaseDevice, ForwardToSession and all session-related messages - Ping, PingRequest, PingResponse Matches compscidr/sair-ochestrator#473 which removes the implementations on the orchestrator side.
compscidr
changed the title
The generated protobuf stubs should not be checked in — they are derived from the .proto files and can get stale. - Add proto/**/*.pb.go to .gitignore - Remove committed .pb.go files from tracking - Update CI workflow to install protoc + Go plugins and run make proto - Update release workflow similarly - Update Dockerfile to generate stubs in the build stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
string repo = 2toAcquireLockRequestin the orchestrator protoSubmitJob,GetJobStatus,Ping,AcquireDevice,ExecuteOnSession,ReleaseDevice,ForwardToSessionrepoquery param on the proxy'sPOST /acquireHTTP endpointScopedPortManager.Acquire→CommandRouter.AcquireLock→ gRPC requestAll device interaction now flows through the lock-based acquire/release model via the proxy. The removed RPCs were from when device-sources and clients talked directly to the orchestrator.
Usage
Related
🤖 Generated with Claude Code