Added support of Clang/LLVM toolset of Visual Studio#648
Open
wizardsd wants to merge 2 commits intoconan-io:masterfrom
Open
Added support of Clang/LLVM toolset of Visual Studio#648wizardsd wants to merge 2 commits intoconan-io:masterfrom
wizardsd wants to merge 2 commits intoconan-io:masterfrom
Conversation
|
|
memsharded
reviewed
Jun 24, 2024
Member
memsharded
left a comment
memsharded
left a comment
There was a problem hiding this comment.
Thanks for your contribution @wizardsd
PRs with changes for Conan 1.X should go to develop branch, not master.
I think the elseif(NOT MSVC_VERSION VERSION_LESS 1930 AND MSVC_VERSION VERSION_LESS 1950) was already merge to develop
Also, please take not that the Conan 1.X integration is no longer recommended. If there are risks of breaking, changes might not be merged. It doesn't seem high risk in this specific case, but we need to check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it possible to use clang-cl.exe as a compiler on Windows in Visual Studio 2022.