Currency news #654
Merged
Currency news #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hi @laliconfigcat, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request adds a news entry about new payment currencies. The changes are consistent with the existing documentation, but the new subsection title does not follow the sentence case convention from the style guide.
🔍 General Feedback
- The changes are applied to both the main documentation and the V1 version, which is correct.
- Please ensure that all titles adhere to the casing conventions outlined in the project's
GUIDELINES.md.
|
|
||
| {/* This page must be in sync with the news page on the Dashboard: https://github.com/configcat/app/blob/master/src/app/home-module/news/news.component.html */} | ||
|
|
||
| ## New payment currencies (AUD, GBP) available |
There was a problem hiding this comment.
🟡 According to the contribution guidelines, subsection titles should be in sentence case.
Suggested change
| ## New payment currencies (AUD, GBP) available | |
| ## New payment currencies (AUD, GBP) available |
|
|
||
| {/* This page must be in sync with the news page on the Dashboard: https://github.com/configcat/app/blob/master/src/app/home-module/news/news.component.html */} | ||
|
|
||
| ## New payment currencies (AUD, GBP) available |
There was a problem hiding this comment.
🟡 According to the contribution guidelines, subsection titles should be in sentence case.
Suggested change
| ## New payment currencies (AUD, GBP) available | |
| ## New payment currencies (AUD, GBP) available |
There was a problem hiding this comment.
This pull request adds a news entry about new payment currencies. The changes are consistent with the existing documentation, but the new subsection title does not follow the sentence case convention from the style guide.
🔍 General Feedback
- The changes are applied to both the main documentation and the V1 version, which is correct.
- Please ensure that all titles adhere to the casing conventions outlined in the project's
GUIDELINES.md.
Correction: My previous review provided an incorrect suggestion. This review corrects that mistake.
|
|
||
| {/* This page must be in sync with the news page on the Dashboard: https://github.com/configcat/app/blob/master/src/app/home-module/news/news.component.html */} | ||
|
|
||
| ## New payment currencies (AUD, GBP) available |
There was a problem hiding this comment.
🟡 According to the contribution guidelines, subsection titles should be in sentence case.
Suggested change
| ## New payment currencies (AUD, GBP) available | |
| ## New payment currencies (AUD, GBP) available |
|
|
||
| {/* This page must be in sync with the news page on the Dashboard: https://github.com/configcat/app/blob/master/src/app/home-module/news/news.component.html */} | ||
|
|
||
| ## New payment currencies (AUD, GBP) available |
There was a problem hiding this comment.
🟡 According to the contribution guidelines, subsection titles should be in sentence case.
Suggested change
| ## New payment currencies (AUD, GBP) available | |
| ## New payment currencies (AUD, GBP) available |
Deploying configcat-docs with
|
| Latest commit: |
7965a3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://818cca69.docs-xmy.pages.dev |
| Branch Preview URL: | https://currencynews.docs-xmy.pages.dev |
z4kn4fein
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the purpose of your pull request
Related issues (only if applicable)
How to test? (only if applicable)
Requirement checklist