Conversation
Signed-off-by: Timo Stamm <ts@timostamm.de>
This was referenced Aug 15, 2025
Signed-off-by: Timo Stamm <ts@timostamm.de>
Signed-off-by: Timo Stamm <ts@timostamm.de>
timostamm
changed the title
Uint8Array to Uint8Array<ArrayBuffer>
smaye81
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the repository from TypeScript 5.6 to 5.9.
Important
TypeScript 5.9 includes breaking changes to lib.d.ts, forcing us to change return types for some functions from
Uint8ArraytoUint8Array<ArrayBuffer>.A similar change was made in Protobuf-ES v2.7.0, and with this PR,
@connectrpc/connectand related packages depend on@bufbuild/protobufv2.7.0 or later.If you are on TypeScript 5.7 or later, you will not see any issues, because it already ships with the new type parameter.
If you are on TypeScript 5.6 and earlier, you may be affected by this change. If you use
Compression,Serialization,UniversalClientFn,UniversalHandlerFnorencodeEnvelopefrom@connectrpc/connect/protocol, the new typeUint8Array<ArrayBuffer>will becomeany, because the compiler does not understand the type.If you are just using Connect clients or servers, you should not see any issues.