Fix 612#613
Merged
chris-laplante merged 5 commits intoconsole-rs:mainfrom Dec 23, 2023
smoelius:fix-612
Merged
Conversation
The test currenty fails.
The `orphan_lines_message_above_progress_bar` tests now pass. But the `multi_progress_println_terminal_wrap` test fails.
The `multi_progress_println_terminal_wrap` test now passes.
chris-laplante
approved these changes
Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #612
Note that I have to eat my words. This PR does not use the approach that @djc suggested:
I tried to do that, but I ran into trouble here:
indicatif/src/draw_target.rs
Line 390 in 8941d5e
That is,
DrawStateWrapper's drop handler usesstate.orphan_lines_countas a number ofstate.linesentries, and I couldn't see a good way around that. So I adapted the other parts of the code to use the same approach.This PR currently has five commits. I think they should make sense indiviudally.