Merged
Conversation
1 task
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Nov 11, 2024
* Fixes red main * Real fix coming in console-rs/indicatif#666 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
djc
approved these changes
Nov 11, 2024
Contributor
Author
|
Thank you for the quick merge! |
Merged
Member
|
@torokati44 see #667. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #665. See: https://crates.io/crates/web-time.
Note that unlike
instant,web-timefalls back tostd::timeon non-WASM, so this kind of conditional exports are not really necessary:Instead, it could unconditionally be
web_time::Instant, if makingweb-timea (really light, to be fair) dependency on non-WASM platforms as well is acceptable. I can update the PR accordingly, if desired.